Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make the ibc-testkit work with no_std #329

Open
plafer opened this issue Jan 6, 2023 · 3 comments
Open

Make the ibc-testkit work with no_std #329

plafer opened this issue Jan 6, 2023 · 3 comments
Labels
A: blocked Admin: blocked by another (internal/external) issue or PR A: good-first-issue Admin: good for newcomers A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews S: no-std Scope: support no_std envs

Comments

@plafer
Copy link
Contributor

plafer commented Jan 6, 2023

Supersedes: #318
Blocked on: informalsystems/tendermint-rs#1258

We should have the ibc-testkit not require std since there's no fundamental reason why it should. This involves:

  1. Don't use Timestamp::now() which reads time from the OS; implement logic to advance time everytime a "mock now()" is called instead.
  2. Use the no_std version of tendermint-testgen when available
@plafer plafer added A: good-first-issue Admin: good for newcomers A: blocked Admin: blocked by another (internal/external) issue or PR S: no-std Scope: support no_std envs A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews labels Jan 6, 2023
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Feb 2, 2023
@Farhad-Shabani Farhad-Shabani modified the milestones: Shepherd open source contributions from users, v0.28.0 Feb 3, 2023
@Farhad-Shabani
Copy link
Member

We have removed mocks-no-std, as of this PR: #825

@github-project-automation github-project-automation bot moved this from 📥 To Do to ✅ Done in ibc-rs Sep 27, 2023
@Farhad-Shabani Farhad-Shabani changed the title Remove mocks-no-std feature Make the mocks feature work with no_std Oct 18, 2023
@Farhad-Shabani
Copy link
Member

Though moved away from the old "mocks-no-std", the core issue still persists.

@github-project-automation github-project-automation bot moved this from ✅ Done to 📥 To Do in ibc-rs Oct 18, 2023
@Farhad-Shabani Farhad-Shabani changed the title Make the mocks feature work with no_std Make the ibc-testkit crate work with no_std Nov 27, 2023
@Farhad-Shabani Farhad-Shabani changed the title Make the ibc-testkit crate work with no_std Make the ibc-testkit work with no_std Nov 27, 2023
@rnbguy
Copy link
Member

rnbguy commented Oct 30, 2024

This is also blocked by la10736/rstest#282 because we are using magic conversion from rstest.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A: blocked Admin: blocked by another (internal/external) issue or PR A: good-first-issue Admin: good for newcomers A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews S: no-std Scope: support no_std envs
Projects
None yet
Development

No branches or pull requests

3 participants