Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: remove traces of deprecated mocks-no-std feature #825

Merged
merged 3 commits into from
Aug 10, 2023

Conversation

Farhad-Shabani
Copy link
Member

Closes: #819


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@Farhad-Shabani Farhad-Shabani marked this pull request as ready for review August 9, 2023 23:14
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5c48d15) 71.49% compared to head (4b5c588) 71.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #825   +/-   ##
=======================================
  Coverage   71.49%   71.49%           
=======================================
  Files         124      124           
  Lines       14960    14960           
=======================================
  Hits        10696    10696           
  Misses       4264     4264           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@plafer plafer merged commit 580fc1d into main Aug 10, 2023
@plafer plafer deleted the farhad/remove-mocks-no-std branch August 10, 2023 14:28
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
* fix: remove mocks-no-std leftovers

* misc: add unclog

* nit: typo
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature mocks-no-std is missing in Cargo.toml
2 participants