Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature mocks-no-std is missing in Cargo.toml #819

Closed
bluele opened this issue Aug 7, 2023 · 2 comments · Fixed by #825
Closed

Feature mocks-no-std is missing in Cargo.toml #819

bluele opened this issue Aug 7, 2023 · 2 comments · Fixed by #825
Assignees
Milestone

Comments

@bluele
Copy link
Contributor

bluele commented Aug 7, 2023

Bug Summary

Even though this feature was removed by PR #700, some code still refers to this: https://github.com/search?q=repo%3Acosmos%2Fibc-rs%20mocks-no-std&type=code

Was the removal of this feature intended in the PR?

Details

Version

@plafer
Copy link
Contributor

plafer commented Aug 7, 2023

I believe we meant to remove all the references to it. @Farhad-Shabani can you confirm?

@Farhad-Shabani
Copy link
Member

I believe we meant to remove all the references to it. @Farhad-Shabani can you confirm?

Correct, mock-no-std was originally designed to toggle the cfg_if dep on or off, which since #700 has been removed. Can get rid of these traces.

@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Aug 9, 2023
@github-project-automation github-project-automation bot moved this from 📥 To Do to ✅ Done in ibc-rs Aug 10, 2023
@Farhad-Shabani Farhad-Shabani self-assigned this Aug 22, 2023
@Farhad-Shabani Farhad-Shabani added this to the v0.44.1 milestone Aug 22, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants