Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: uniformity in ownership and borrowing patterns for *_update_meta args #1072

Merged

Conversation

Farhad-Shabani
Copy link
Member

@Farhad-Shabani Farhad-Shabani commented Feb 1, 2024

Description

This is actually part of #972. I missed mentioning it there.

Integration tests: informalsystems/basecoin-rs#151


PR author checklist:

  • Linked to GitHub issue.
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (0c1e8a9) 66.70% compared to head (2330339) 66.71%.

Files Patch % Lines
ibc-clients/ics07-tendermint/src/client_state.rs 66.66% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1072   +/-   ##
=======================================
  Coverage   66.70%   66.71%           
=======================================
  Files         204      204           
  Lines       20427    20447   +20     
=======================================
+ Hits        13626    13641   +15     
- Misses       6801     6806    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Farhad-Shabani Farhad-Shabani merged commit caee889 into main Feb 1, 2024
@Farhad-Shabani Farhad-Shabani deleted the farhda/consistent-ownership-for-update-meta-methods branch February 1, 2024 22:19
@Farhad-Shabani Farhad-Shabani added this to the 0.51.0 milestone Feb 6, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants