Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove pub from MockConsensusState::root field #1259

Merged
merged 8 commits into from
Jun 17, 2024
Merged

Remove pub from MockConsensusState::root field #1259

merged 8 commits into from
Jun 17, 2024

Conversation

seanchen1991
Copy link
Contributor

Closes: #1216

Description

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@codecov Codecov
Copy link

codecov bot commented Jun 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.27%. Comparing base (588f7eb) to head (6e60036).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1259   +/-   ##
=======================================
  Coverage   67.27%   67.27%           
=======================================
  Files         235      235           
  Lines       23538    23538           
=======================================
  Hits        15836    15836           
  Misses       7702     7702

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rnbguy
rnbguy approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@rnbguy rnbguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good 👍

@seanchen1991 seanchen1991 added this pull request to the merge queue Jun 17, 2024
Merged via the queue into main with commit 8424f69 Jun 17, 2024
19 checks passed
@seanchen1991 seanchen1991 deleted the sean/mock-consensus-state-no-commitment-root branch June 17, 2024 19:03
Farhad-Shabani pushed a commit that referenced this pull request Sep 9, 2024
@seanchen1991 @rnbguy
Remove pub from MockConsensusState::root field (#1259)
85b043e 
* Remove `pub` from root field

* Add incomplete comment to `MockConsensusState`

* Comment formatting

* Address rust 1.79 clippy error

* Improve MockConsensusState doc comment

* ignore dotenv file

* add doc links in doc comment

---------

Co-authored-by: Ranadeep Biswas <mail@rnbguy.at>
Co-authored-by: Rano | Ranadeep <ranadeep@informal.systems>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@rnbguy rnbguy rnbguy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MockConsensusState should not have commitment root
2 participants
@seanchen1991 @rnbguy