Skip to content

Define a new validate_signer interface to enable customizable Signer validation across all handlers #651

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
May 1, 2023

Conversation

Farhad-Shabani
Copy link
Member

Closes: #619


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch coverage: 92.42% and no project coverage change.

Comparison is base (ee1dbce) 73.07% compared to head (37ed081) 73.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #651   +/-   ##
=======================================
  Coverage   73.07%   73.07%           
=======================================
  Files         126      126           
  Lines       15678    15630   -48     
=======================================
- Hits        11456    11421   -35     
+ Misses       4222     4209   -13     
Impacted Files Coverage Δ
crates/ibc/src/applications/transfer/error.rs 12.50% <ø> (+0.50%) ⬆️
crates/ibc/src/applications/transfer/packet.rs 52.63% <0.00%> (+9.15%) ⬆️
crates/ibc/src/core/context.rs 83.51% <ø> (ø)
crates/ibc/src/core/ics02_client/error.rs 20.83% <ø> (+0.83%) ⬆️
...tes/ibc/src/core/ics02_client/msgs/misbehaviour.rs 4.54% <0.00%> (ø)
crates/ibc/src/core/ics03_connection/error.rs 7.69% <ø> (+0.54%) ⬆️
crates/ibc/src/core/ics04_channel/error.rs 0.00% <ø> (ø)
...tes/ibc/src/applications/transfer/msgs/transfer.rs 46.66% <33.33%> (+0.87%) ⬆️
...ibc/src/core/ics02_client/handler/create_client.rs 82.89% <100.00%> (+1.20%) ⬆️
...ibc/src/core/ics02_client/handler/update_client.rs 95.12% <100.00%> (-0.12%) ⬇️
... and 36 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Farhad-Shabani Farhad-Shabani marked this pull request as ready for review April 26, 2023 23:36
Copy link
Contributor

@plafer plafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Please confirm you like the small changes I made

@Farhad-Shabani Farhad-Shabani merged commit a787f59 into main May 1, 2023
@Farhad-Shabani Farhad-Shabani deleted the farhad/signer-validaiton-interface branch May 1, 2023 15:24
@Farhad-Shabani Farhad-Shabani added this to the v0.39.0 milestone May 1, 2023
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
…le `Signer` validation across all handlers (#651)

* Add customizable Signer validation

* docstring and method name

* changelog

---------

Co-authored-by: Philippe Laferriere <plafer@protonmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core] Add a Signer validation method to include host-specific checks for validate() processes
2 participants