Skip to content

fix(ics02)!: modify MsgUpgradeClient to utilize CommitmentProofBytes for the proofs #746

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 137 commits into from

Conversation

Farhad-Shabani
Copy link
Member

Closes: #739


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch coverage: 79.73% and project coverage change: +0.83 🎉

Comparison is base (1c5b50b) 72.33% compared to head (d87453c) 73.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #746      +/-   ##
==========================================
+ Coverage   72.33%   73.16%   +0.83%     
==========================================
  Files         116      124       +8     
  Lines       15529    16070     +541     
==========================================
+ Hits        11233    11758     +525     
- Misses       4296     4312      +16     
Impacted Files Coverage Δ
crates/ibc/src/core/handler.rs 88.60% <ø> (ø)
crates/ibc/src/core/ics02_client/client_state.rs 0.00% <0.00%> (-78.95%) ⬇️
crates/ibc/src/core/ics03_connection/error.rs 7.69% <ø> (ø)
...src/core/ics04_channel/events/packet_attributes.rs 10.82% <ø> (ø)
.../src/core/ics04_channel/handler/acknowledgement.rs 94.39% <ø> (ø)
...c/core/ics04_channel/handler/chan_close_confirm.rs 97.57% <ø> (ø)
.../src/core/ics04_channel/handler/chan_close_init.rs 97.19% <ø> (ø)
...bc/src/core/ics04_channel/handler/chan_open_ack.rs 97.50% <ø> (ø)
...rc/core/ics04_channel/handler/chan_open_confirm.rs 97.70% <ø> (ø)
...c/src/core/ics04_channel/handler/chan_open_init.rs 96.34% <ø> (ø)
... and 39 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Farhad-Shabani
Copy link
Member Author

Superseded with #748

@Farhad-Shabani Farhad-Shabani deleted the farhad/modify-msg-upgrade-client branch October 12, 2023 17:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ICS02] Design flaw of verify_upgrade_client function of ClientState trait
2 participants