Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: Adds bundle helper ABI #66

Merged
merged 2 commits into from
Dec 19, 2024
Merged

feat: Adds bundle helper ABI #66

merged 2 commits into from
Dec 19, 2024

Conversation

dylanlott
Copy link
Contributor

@dylanlott dylanlott commented Dec 10, 2024 •
edited
Loading

TL;DR

Added BundleHelper contract ABI and bindings to support bundle submission.

Changes

  • Added new BundleHelper.json ABI file with contract interface definitions
  • Integrated BundleHelper module into the bindings system
  • Added BundleHelper to the public exports in lib.rs
  • Fixed a typo in contract bindings documentation comment

@dylanlott Graphite App
Copy link
Contributor Author

dylanlott commented Dec 10, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@dylanlott dylanlott added the enhancement New feature or request label Dec 10, 2024 — with Graphite App
@dylanlott dylanlott marked this pull request as ready for review December 10, 2024 23:07
@dylanlott dylanlott marked this pull request as draft December 10, 2024 23:07
@dylanlott dylanlott force-pushed the dylan/adds-bundle-helper-abi branch 9 times, most recently from 1ad8639 to 2f0908b Compare December 12, 2024 19:27
graphite-app[bot]
graphite-app bot reviewed Dec 12, 2024
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
src/bindings.rs Outdated Show resolved Hide resolved
@dylanlott dylanlott changed the title adds bundle helper ABI feat: adds bundle helper ABI Dec 16, 2024
@dylanlott dylanlott changed the title feat: adds bundle helper ABI feat: Adds bundle helper ABI Dec 17, 2024
@dylanlott dylanlott marked this pull request as ready for review December 17, 2024 03:53
@dylanlott dylanlott marked this pull request as draft December 17, 2024 03:53
@dylanlott dylanlott force-pushed the dylan/adds-bundle-helper-abi branch from b64b3f3 to 0ce0fc4 Compare December 17, 2024 18:50
@dylanlott dylanlott marked this pull request as ready for review December 17, 2024 18:59
@dylanlott dylanlott self-assigned this Dec 17, 2024
anna-carroll
anna-carroll approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@anna-carroll anna-carroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dylanlott Graphite App
Copy link
Contributor Author

dylanlott commented Dec 19, 2024 •
edited
Loading

Merge activity

  • Dec 19, 2:46 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 19, 2:46 PM EST: A user merged this pull request with Graphite.

@dylanlott dylanlott merged commit af8027a into main Dec 19, 2024
5 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@anna-carroll anna-carroll anna-carroll approved these changes

Assignees

@dylanlott dylanlott

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dylanlott @anna-carroll