Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: render css entrypoints as link tags in development #185

Merged
merged 2 commits into from
Jan 31, 2022
Merged

fix: render css entrypoints as link tags in development #185

merged 2 commits into from
Jan 31, 2022

Conversation

jacksleight
Copy link
Contributor

@jacksleight jacksleight commented Jan 31, 2022 •
edited
Loading

As mentioned in https://github.com/innocenzi/laravel-vite/discussions/180.

This makes CSS entrypoints output as link tags in dev mode instead of script tags, preventing the CSS load delay and FOUC.

@jacksleight jacksleight marked this pull request as draft January 31, 2022 11:42
@jacksleight jacksleight marked this pull request as ready for review January 31, 2022 11:48
@innocenzi innocenzi changed the title Add css entrypoints as link tags in dev mode fix: render css entrypoints as link tags in development Jan 31, 2022
@innocenzi innocenzi merged commit c317ad9 into innocenzi:main Jan 31, 2022
@innocenzi
Copy link
Owner

Perfect, thanks!

@jacksleight jacksleight deleted the dev-link-tag branch January 31, 2022 11:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@innocenzi innocenzi innocenzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacksleight @innocenzi