Repin all possible vCPUs, not just ones in use #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to increse the amount of vCPUs in a VM, we were greeted with a cgroup error: ``` virCgroupSetValueRaw:502 : Unable to write to '/sys/fs/cgroup/machine.slice/.../vcpu6/cpuset.cpus': Numerical result out of range ``` It turns out that when live repinning the VM on the new hypervisor, we were iterating only over the amount of vCPUs assigned to the VM (for example, 0 to 5) instead of the max amount of vCPUs assignable (coming from props.max_cpus). Now we iterate over the max amount of vCPUs assignable and pin them to the local hypervisor topology.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to increse the amount of vCPUs in a VM, we were greeted with a cgroup error:
It turns out that when live repinning the VM on the new hypervisor, we were iterating only over the amount of vCPUs assigned to the VM (for example, 0 to 5) instead of the max amount of vCPUs assignable (coming from props.max_cpus).
Now we iterate over the max amount of vCPUs assignable and pin them to the local hypervisor topology.
I tested it on machines with two NUMA nodes and machines with single NUMA nodes.