Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove utf8 encoding comments #32

Merged
merged 8 commits into from
Dec 18, 2023
Merged

Conversation

Netzberufler
Copy link
Member

@Netzberufler Netzberufler commented Dec 14, 2023

Removes the -*- coding: utf-8 -*- comments for the new Sniff in our PHP Coding standards:
inpsyde/php-coding-standards#77

Context: https://inpsyde.slack.com/archives/C03LQSP85UM/p1702573675052719

@Netzberufler Netzberufler marked this pull request as ready for review December 14, 2023 16:48
Copy link
Member

@tyrann0us tyrann0us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Used the opportunity to add some missing strict type declarations.

tests/PHPUnit/bootstrap.php Show resolved Hide resolved
src/Admin/MenuItemProvider.php Show resolved Hide resolved
wp-stash.php Show resolved Hide resolved
Netzberufler and others added 3 commits December 18, 2023 10:25
Co-authored-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com>
Signed-off-by: Thomas Weichselbaumer <thomas.weichselbaumer@netzberufler.de>
Co-authored-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com>
Signed-off-by: Thomas Weichselbaumer <thomas.weichselbaumer@netzberufler.de>
Co-authored-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com>
Signed-off-by: Thomas Weichselbaumer <thomas.weichselbaumer@netzberufler.de>
@Netzberufler Netzberufler merged commit 02ab8d7 into master Dec 18, 2023
11 checks passed
@Netzberufler Netzberufler deleted the remove-utf8-encoding-comments branch December 18, 2023 09:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants