This repository has been archived by the owner on Feb 28, 2023. It is now read-only.
Add danseBlockNumber to iele config #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loverdos
reviewed
Oct 2, 2018
| @@ -50,7 +50,7 @@ message EthereumConfig { | |||
| } | |||
|
|
|||
| message IeleConfig { | |||
| // empty | |||
| bytes danseBlockNumber = 1; | |||
There was a problem hiding this comment.
Do we need to make this optional?
There was a problem hiding this comment.
I think not, do we?
There was a problem hiding this comment.
No, you can make it required and always populate it with a value from Mantis's config. Just remember to bump the protobuf version field.
There was a problem hiding this comment.
It seems that in protobuf 3 land there are no required fields and everything is optional. If we need to distinguish between the absense of a field and its default value, then we need wrappers.
See also
- why messge type remove 'required,optional'? protocolbuffers/protobuf#2497
- https://github.com/protocolbuffers/protobuf/blob/6a51c03823448a9229c50795ae0d984ac0fe4fbd/src/google/protobuf/wrappers.proto#L31
Bumping our version is of course something we need to do anyway. So 1.2 or 2.0?
loverdos
approved these changes
Oct 11, 2018
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
input-output-hk/mantis-cardano#3