[Kaizen] Unflake RegularSynchSpec #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzajkowski
commented
Jul 9, 2021
| @@ -474,7 +476,7 @@ class RegularSyncSpec | |||
| peersClient.setAutoPilot(new PeersClientAutoPilot) | |||
| override lazy val branchResolution: BranchResolution = stub[BranchResolution] | |||
| (blockchainReader.getBestBlockNumber _).when().returns(0) | |||
| (branchResolution.resolveBranch _).when(*).returns(NewBetterBranch(Nil)).repeat(10) | |||
| (branchResolution.resolveBranch _).when(*).returns(NewBetterBranch(Nil)).atLeastOnce() | |||
There was a problem hiding this comment.
not convinced if this is required but the repeat(10) seems arbitrary.
There was a problem hiding this comment.
Indeed, atLeastOnce or anyNumberOf Times seems more appropriate. I just always wonder why does a method needs to be called so many times. Is it a recursive one?
There was a problem hiding this comment.
the logic in RegularSync will run a retry on failure. the failure is the missing node (vide a bit lower) which should result in some logic and a retry. the 10 used to be 1 a long time ago.
AnastasiiaL
approved these changes
Jul 9, 2021
jvdp
reviewed
Jul 9, 2021
| @@ -86,6 +86,8 @@ class RegularSyncSpec | |||
| def sync[T <: Fixture](test: => T): Future[Assertion] = | |||
| Future { | |||
| test | |||
| // this makes sure that actors are all done after the test (believe me, afterEach does not work with mocks) | |||
| TestKit.shutdownActorSystem(testSystem) | |||
There was a problem hiding this comment.
This 'fixture' pretty weird... are there any other tests with this?
There was a problem hiding this comment.
it's custom to this test, haven't seen it any other place.
jvdp
approved these changes
Jul 9, 2021
leo-bogastry
approved these changes
Jul 9, 2021
dzajkowski
force-pushed
the
kaizen/unflake-regular-synch-spec
branch
from
8107cc6 to
5539597
Compare
AurelienRichez
approved these changes
Jul 9, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the reason for the flakiness is a race condition between scalamock and akka testkit. by guaranteeing that actors will be shutdown when scalamock is closing down its stubs the possibility for the race is removed.