[ETCM-1028] fix retesteth config after version upgrade to v0.1.1-eip1559 #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we leave a note for the person that will update the |
jvdp
approved these changes
Jul 16, 2021
strauss-m
changed the title
Sure, where's the best place to do it ? I don't see any related jira ticket or in progress PR for such a task. |
Sorry I was being a bit vague. I'll create a ticket and a note on it there. |
AurelienRichez
approved these changes
Jul 16, 2021
|
Nice 👍 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
retesteth doesn't launch anymore after version update
Proposed Solution
retesteth seems to expect the London fork in the config file, which is currently not present since Mantis doesn't support Berlin neither London.
A workaround seems to declare London as a supported fork, but not Berlin.
That way, Berlin tests are skipped, and since there are no London tests in the repository, retesteth just runs all tests up to and including the Istanbul ones.
An issue has been opened to further investigate a potential retesteth bug or misunderstood documentation: ethereum/retesteth#141
Please be aware that the London inclusion asks retesteth to run all the London-related test. Currently, they are not yet included, but they will once https://jira.iohk.io/browse/ETCM-1033 is done. The workaround won't work anymore at that point.