[ETCM-28] petersburg changes #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmrozek
force-pushed
the
etcm-28-petersbug-changes
branch
from
64e5bc1 to
9b1bb44
Compare
…mantis into etcm-28-petersbug-changes � Conflicts: � src/main/scala/io/iohk/ethereum/extvm/VMServer.scala � src/main/scala/io/iohk/ethereum/vm/BlockchainConfigForEvm.scala � src/main/scala/io/iohk/ethereum/vm/EvmConfig.scala � src/main/scala/io/iohk/ethereum/vm/VM.scala � src/test/scala/io/iohk/ethereum/extvm/VMClientSpec.scala � src/test/scala/io/iohk/ethereum/vm/Fixtures.scala � src/test/scala/io/iohk/ethereum/vm/VMSpec.scala
| @@ -37,6 +37,10 @@ | |||
| # https://ecips.ethereumclassic.org/ECIPs/ecip-1088 | |||
| phoenix-block-number = "1000000000000000000" | |||
|
|
|||
| # Petersburg fork block number (ETH only) | |||
| # https://github.com/ethereum/EIPs/blob/master/EIPS/eip-1716.md | |||
| petersburg-block-number = "7280000" | |||
There was a problem hiding this comment.
hmm mayble as we are adding it, we should also change constantinople fork block number in config to 7280000 ? (https://media.consensys.net/the-constantinople-hard-fork-what-you-need-to-know-d438a91dec3f)
mmrozek
force-pushed
the
etcm-28-petersbug-changes
branch
from
e97a040 to
9f7977b
Compare
…ttps://github.com/input-output-hk/mantis into etcm-28-petersbug-changes � Conflicts: � src/main/scala/io/iohk/ethereum/extvm/VMServer.scala � src/main/scala/io/iohk/ethereum/vm/BlockchainConfigForEvm.scala � src/main/scala/io/iohk/ethereum/vm/EvmConfig.scala � src/test/scala/io/iohk/ethereum/extvm/VMClientSpec.scala � src/test/scala/io/iohk/ethereum/vm/Fixtures.scala � src/test/scala/io/iohk/ethereum/vm/VMSpec.scala
KonradStaniec
approved these changes
Aug 26, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes related to Petersburg fork