Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[FIX] Add mocked miner validations #678

Merged
merged 2 commits into from
Sep 18, 2020
Merged

[FIX] Add mocked miner validations #678

merged 2 commits into from
Sep 18, 2020

Conversation

ntallar
Copy link

@ntallar ntallar commented Sep 17, 2020 •
edited
Loading

Description

A couple of mocked miner fixes:

  • Adds the mocked miner as one of the allowed protocols
  • Adds mocked pow validations so that imported blocks created by mock miner doesn't fail

Testing

Setup:

  • mantis.consensus.protocol = mocked
  • mantis.consensus.mining-enabled = true
  • mantis.blockchains.network = "private"
  • mantis.sync.do-fast-sync = false

And use the mocked miner QA endpoint to generate blocks

@ntallar ntallar force-pushed the fix/mocked-miner-validations branch from ac0a4f4 to 52cec05 Compare September 17, 2020 15:53
@ntallar ntallar force-pushed the fix/mocked-miner-validations branch from 52cec05 to a4ab89e Compare September 17, 2020 16:01
@ntallar ntallar requested a review from mmrozek September 17, 2020 16:05
@ntallar ntallar marked this pull request as ready for review September 17, 2020 16:08
mmrozek
mmrozek approved these changes Sep 18, 2020
View reviewed changes
Copy link
Contributor

@mmrozek mmrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mirkoAlic mirkoAlic merged commit 621a131 into develop Sep 18, 2020
@mirkoAlic mirkoAlic deleted the fix/mocked-miner-validations branch September 18, 2020 11:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mmrozek mmrozek mmrozek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ntallar @mmrozek @mirkoAlic