Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Chore] Single line for message logging #779

Merged
merged 4 commits into from
Nov 6, 2020
Merged

Conversation

ntallar
Copy link

@ntallar ntallar commented Nov 5, 2020

Description

As we are currently logging all messages, it can be a bit of a pain to read logs with all the structures being printed as multiline, this changes for them being single line.

(my first thought was removing that logging entirely, but it ended up being useful for tracking blocks on the testnet)

Testing

Checking that I didn't miss any structure or message

@ntallar ntallar requested a review from mirkoAlic November 5, 2020 19:38
@mirkoAlic
Copy link
Contributor

mirkoAlic commented Nov 6, 2020

I think there are still some multiline messages (i search by stripMargin).. what about these ones?

  • src/main/scala/io/iohk/ethereum/domain/SignedTransaction.scala
  • src/main/scala/io/iohk/ethereum/domain/Receipt.scala
  • src/main/scala/io/iohk/ethereum/domain/Block.scala
  • src/main/scala/io/iohk/ethereum/blockchain/sync/regular/ImportMessages.scala
  • src/main/scala/io/iohk/ethereum/blockchain/sync/SyncSchedulerActorState.scala
  • src/main/scala/io/iohk/ethereum/blockchain/sync/FastSync.scala
  • src/main/scala/io/iohk/ethereum/ledger/BlockPreparator.scala

@ntallar
Copy link
Author

ntallar commented Nov 6, 2020

src/main/scala/io/iohk/ethereum/blockchain/sync/SyncSchedulerActorState.scala
src/main/scala/io/iohk/ethereum/blockchain/sync/FastSync.scala
src/main/scala/io/iohk/ethereum/ledger/BlockPreparator.scala

I addressed all but these, as they are not structure/message logs nor they have been a nuisance to me when running Mantis locally, but I can change them if you prefer

@mirkoAlic
Copy link
Contributor

mirkoAlic commented Nov 6, 2020

src/main/scala/io/iohk/ethereum/blockchain/sync/SyncSchedulerActorState.scala
src/main/scala/io/iohk/ethereum/blockchain/sync/FastSync.scala
src/main/scala/io/iohk/ethereum/ledger/BlockPreparator.scala

I addressed all but these, as they are not structure/message logs nor they have been a nuisance to me when running Mantis locally, but I can change them if you prefer

hmm...maybe just the one related to FastSync? or change the rest just to be consistent on the approach WDYT?

@mmrozek
Copy link
Contributor

mmrozek commented Nov 6, 2020

Just curious: what is wrong with multiline logs? We have already implemented logging.json-output to use with graylog

@ntallar
Copy link
Author

ntallar commented Nov 6, 2020

That locally I like running Mantis with logging.json-output set to false 😛 this change is not for the testnet but for me or anyone that runs Mantis locally with that disabled (and it doesn't affect those who don't disable it)

@ntallar ntallar merged commit 5b2ce03 into develop Nov 6, 2020
@ntallar ntallar deleted the chore/singleline-msg-logs branch November 6, 2020 19:07
kapke pushed a commit that referenced this pull request Nov 16, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants