-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Chore] Single line for message logging #779
Conversation
I think there are still some multiline messages (i search by
|
I addressed all but these, as they are not structure/message logs nor they have been a nuisance to me when running Mantis locally, but I can change them if you prefer |
hmm...maybe just the one related to FastSync? or change the rest just to be consistent on the approach WDYT? |
Just curious: what is wrong with multiline logs? We have already implemented |
That locally I like running Mantis with logging.json-output set to false 😛 this change is not for the testnet but for me or anyone that runs Mantis locally with that disabled (and it doesn't affect those who don't disable it) |
Description
As we are currently logging all messages, it can be a bit of a pain to read logs with all the structures being printed as multiline, this changes for them being single line.
(my first thought was removing that logging entirely, but it ended up being useful for tracking blocks on the testnet)
Testing
Checking that I didn't miss any structure or message