[ETCM-411] Add optional param to generate more keys at once #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmrozek
reviewed
Nov 25, 2020
|
one one side it makes sense, on the other side i know that Shay is using it in that format so it would be probably easier for him to use it that way without any learning curve and changes in tooling |
mmrozek
approved these changes
Nov 25, 2020
mirkoAlic
reviewed
Nov 25, 2020
| * priv-key-hex (32 bytes) | ||
| * pub-key-hex (64 bytes) | ||
| * | ||
| * Run: | ||
| * ./eckeygen > mantis-datadir/node.key | ||
| * ./eckeygen [n] > mantis-datadir/node.key | ||
| * | ||
| * to generate the private key for the node. Note that only the private key will be read upon Mantis boot, |
There was a problem hiding this comment.
(minor) "[...] Note that only the first private key will be read upon Mantis boot"
There was a problem hiding this comment.
actually it is more general as even if we generate one pair, only the private key is read at boot time and then whole key pair is regenerated based on this key keyPairFromPrvKey(Hex.decode(privHex))
mirkoAlic
approved these changes
Nov 25, 2020
KonradStaniec
force-pushed
the
etcm-411/improve-key-gen
branch
from
abb12b3 to
e513202
Compare
mmrozek
reviewed
Nov 25, 2020
| @@ -27,6 +29,22 @@ object CliCommands { | |||
| } | |||
| } | |||
|
|
|||
| private val GenerateKeyPairs: Command[String] = | |||
There was a problem hiding this comment.
Please add a test case to CliCommandsSpec and update README
KonradStaniec
force-pushed
the
etcm-411/improve-key-gen
branch
from
e513202 to
daa32c8
Compare
KonradStaniec
force-pushed
the
etcm-411/improve-key-gen
branch
from
daa32c8 to
074ae4c
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add possibility to generate n keys (ported from other project)