[ETCM-415] Fix random subset of peers where block is broadcasted #814
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes random subset of peers not working properly
Given a set, Random.shuffle doesn't work properly (kudos to @dmitry-worker for finding this!):
Random.shuffle((1 to 10).toSet).take(5) == (1 to 10).toSet.take(5)
, the shuffle does nothing (this seems to happen with more than 4 elements as the HashSet implementation is used)Random.shuffle((1 to 10).toSet) == Random.shuffle((1 to 5).toSet)
, adding more elements doesn't alter the result of the shuffleThis might have lead into bad propagation of blocks, increasing the chances of having forks on our testnet
Proposed Solution