Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Fix] - Made public key from signature recover method safer #819

Merged
merged 1 commit into from
Nov 27, 2020
Merged

[Fix] - Made public key from signature recover method safer #819

merged 1 commit into from
Nov 27, 2020

Conversation

pslaski
Copy link
Contributor

@pslaski pslaski commented Nov 27, 2020

Description

ECDSASignature.recoverPubBytes is using an external library code which is throwing exceptions.

Proposed Solution

Use Try in ECDSASignature.recoverPubBytes method.

@pslaski pslaski force-pushed the fix-safer-public-key-restore branch from 1f5993c to 252dd0c Compare November 27, 2020 14:25
@pslaski pslaski merged commit 6a4bb70 into develop Nov 27, 2020
@pslaski pslaski deleted the fix-safer-public-key-restore branch November 27, 2020 14:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@KonradStaniec KonradStaniec KonradStaniec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pslaski @KonradStaniec