Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Chore] Configure the future address of the treasury contract (nomad testnet) #822

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

ntallar
Copy link

@ntallar ntallar commented Dec 1, 2020

Description

Prepare our nomad testnet for deploying the treasury contract

Proposed Solution

Due to our check of account existance on the block execution, the treasury contract can be deployed on an testnet with ECIP 1098 already enabled by:

  1. @KonradStaniec created the contract deploying account (0xfca4134ea4203dbfeffbe55f8568ac2ff41f5f7f) and derivated the expected treasury address (0x0358e65dfe67b350eb827ffa17a82e7bb5f4c0c6)
  2. This PR, add it to our configurations (it's a requirement that the treasury address before it to never be used)
  3. Deploy the treasury contract

Testing

Connect to the nomad testnet and execute blocks without any issues

@ntallar ntallar requested a review from KonradStaniec December 1, 2020 12:26
@ntallar ntallar force-pushed the chore/nomad-testnet-treasury-address branch from 06884bf to 6f04496 Compare December 1, 2020 12:27
Copy link
Contributor

@KonradStaniec KonradStaniec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add to steps that treasury need to be deployed by someone controlling account with address 0xfca4134ea4203dbfeffbe55f8568ac2ff41f5f7f as a first transaction of this address (contract address is derived from creator address and creator nonce)

@ntallar ntallar merged commit 7031c7f into develop Dec 1, 2020
@ntallar ntallar deleted the chore/nomad-testnet-treasury-address branch December 1, 2020 13:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants