Fixed concurrency issue that allowed multiple miners instantiation. #909
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a refresh of #777
Description
Concurrent
EthashConsensus.startMiningProcess()
method invocation can lead to several miner actors.There's no thread mutual exclusion and atomicity between
AtomicReference.get()
andAtomicReference.set()
calls.Proposed Solution
synchronized
orReentrantReadWrite
is recommended to ensure that only one miner is created.AtomicReference
is redundant, since no CAS-related methods are used.Solution assumes that no thread synchronization is needed when miner already exists.