Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix explorer packaging in releases #2170

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Fix explorer packaging in releases #2170

merged 2 commits into from
Dec 12, 2024

Conversation

Alenar
Copy link
Collaborator

@Alenar Alenar commented Dec 11, 2024 •
edited
Loading

Content

This PR fix the explorer packaging when doing releases.

package-distribution script enhancement

  • allow to change the prepended name of the archive built (default to mithril to keep current behaviour)
  • allow to omit the --target so this script can be used to packages project aht have a "target os" and or "target arch" (such as web projects)

Unstable release changes

Pre-release changes

  • Include the explorer package in pre-release

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@Alenar Alenar self-assigned this Dec 11, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 11, 2024 •
edited
Loading

Test Results

    4 files  ±0     52 suites  ±0   9m 54s ⏱️ +13s
1 428 tests ±0  1 428 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 639 runs  ±0  1 639 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a5188ec. ± Comparison against base commit 404212a.

♻️ This comment has been updated with latest results.

jpraynaud
jpraynaud approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Alenar Alenar temporarily deployed to testing-preview December 11, 2024 16:05 — with GitHub Actions Inactive
@Alenar
feat(ci): allow to set the archive name and omit the target when pack…
53a4ba5 
…aging a distribution

This allow the python script to be reused for web packages (that don't
have a target os and arch).
@Alenar
fix(ci): properly package explorer with unstable and pre-release
a5188ec 
The explorer was incorrectly included in the unstable release with all
its files uncompressed instead of being in one archive.
It also wasn't included when creating pre-releases.
@Alenar Alenar force-pushed the djo/package-explorer-in-releases branch from a52fd37 to a5188ec Compare December 11, 2024 16:05
@Alenar Alenar temporarily deployed to testing-preview December 11, 2024 16:15 — with GitHub Actions Inactive
@Alenar Alenar temporarily deployed to testing-sanchonet December 11, 2024 16:15 — with GitHub Actions Inactive
@Alenar Alenar merged commit 572f00e into main Dec 12, 2024
51 of 53 checks passed
@Alenar Alenar deleted the djo/package-explorer-in-releases branch December 12, 2024 11:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sfauvel sfauvel sfauvel approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

@dlachaume dlachaume dlachaume approved these changes

Assignees

@Alenar Alenar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Alenar @sfauvel @jpraynaud @dlachaume