Feat: implement the Ancillary sub builder for Incremental Cardano DB #2180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlachaume
changed the title
dlachaume
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
dlachaume
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
sfauvel
reviewed
Dec 17, 2024
mithril-aggregator/src/artifact_builder/cardano_database_artifacts/ancillary.rs
Outdated
Show resolved
Hide resolved
sfauvel
reviewed
Dec 17, 2024
mithril-aggregator/src/artifact_builder/cardano_database_artifacts/ancillary.rs
Outdated
Show resolved
Hide resolved
dlachaume
force-pushed
the
ensemble/2151/implement-sub-builders
branch
from
22e0851 to
ba848e2
Compare
dlachaume
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
dlachaume
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
jpraynaud
approved these changes
Dec 17, 2024
mithril-aggregator/src/artifact_builder/cardano_database_artifacts/ancillary.rs
Show resolved
Hide resolved
mithril-aggregator/src/artifact_builder/cardano_database_artifacts/ancillary.rs
Outdated
Show resolved
Hide resolved
Alenar
approved these changes
Dec 17, 2024
dlachaume
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
dlachaume
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
Co-authored-by: Sébastien Fauvel <sfauvel@users.noreply.github.com>
…tabase artifact builder
…gregator dependency builder Co-authored-by: Sébastien Fauvel <sfauvel@users.noreply.github.com>
- remove useless `Aggregator` reference in the `AncillaryFileUploader` trait name - rename ancillary builder unit test to reflect `upload_archive` behavior
…actBuilder` Co-authored-by: Sébastien Fauvel <sfauvel@users.noreply.github.com>
dlachaume
force-pushed
the
ensemble/2151/implement-sub-builders
branch
2 times, most recently
from
2cd02c2 to
7736c7f
Compare
…facts directory are properly created
* mithril-aggregator from `0.6.3` to `0.6.4` * mithril-common from `0.4.96` to `0.4.97`
dlachaume
force-pushed
the
ensemble/2151/implement-sub-builders
branch
from
7736c7f to
32d1ef4
Compare
dlachaume
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
dlachaume
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR includes the first implementation of the ancillary builder for the Incremental Cardano Database.
It handles the upload of ancillary artifacts using a Local Uploader and adds the returned locations to the
CardanoDatabaseSnapshot. The creation and verification of the ancillary archive will be handled in a separate PR.Pre-submit checklist
Issue(s)
Relates to #2151