feat: extend Snapshotter to archive only specific files and directories
#2189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlachaume
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
dlachaume
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
dlachaume
force-pushed
the
ensemble/2151/extend-snapshotter-for-specific-files-directories
branch
from
2f79c05 to
4331d07
Compare
dlachaume
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
dlachaume
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
Alenar
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
LGTM 🚀
I had a sightly different idea regarding the snapshotter, but your design may work as well and is flexible enough to be adapted if needed.
What I had in mind was to let the snapshotter compute itself the subset of files that must be included in a ancillary archive, the only parameter to pass would be the immutable to include.
…ries Co-authored-by: Sébastien Fauvel <sfauvel@users.noreply.github.com>
* mithril-aggregator from `0.6.5` to `0.6.6`
dlachaume
force-pushed
the
ensemble/2151/extend-snapshotter-for-specific-files-directories
branch
from
4331d07 to
58133cb
Compare
dlachaume
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
dlachaume
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
12 tasks
dlachaume
deleted the
ensemble/2151/extend-snapshotter-for-specific-files-directories
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR includes an update to the
Snapshotterthat allows it to create archives from specific directories and files.It’s a preparatory step for the creation of archives from ancillary files.
Pre-submit checklist
Issue(s)
Relates to #2151