-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Feat: immutable file digests route for CardanoDatabase
artifacts aggregator
#2204
Merged
jpraynaud
merged 20 commits into
main
from
jpraynaud/2174-digests-route-cardano-database-aggregator
Jan 9, 2025
Merged
Feat: immutable file digests route for CardanoDatabase
artifacts aggregator
#2204
jpraynaud
merged 20 commits into
main
from
jpraynaud/2174-digests-route-cardano-database-aggregator
Jan 9, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8616fdb
to
0cf2629
Compare
…leFileDigestRepository'
…seDigestListItemMessage' messages
0cf2629
to
f1bbaf6
Compare
dlachaume
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
mithril-aggregator/src/database/repository/immutable_file_digest_repository.rs
Outdated
Show resolved
Hide resolved
mithril-aggregator/src/database/repository/immutable_file_digest_repository.rs
Outdated
Show resolved
Hide resolved
sfauvel
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Some refactoring suggestions
mithril-aggregator/src/database/query/immutable_file_digest/delete_immutable_file_digest.rs
Outdated
Show resolved
Hide resolved
mithril-aggregator/src/database/query/immutable_file_digest/get_immutable_file_digest.rs
Outdated
Show resolved
Hide resolved
mithril-aggregator/src/database/query/immutable_file_digest/upsert_immutable_file_digest.rs
Outdated
Show resolved
Hide resolved
mithril-aggregator/src/database/repository/immutable_file_digest_repository.rs
Outdated
Show resolved
Hide resolved
Alenar
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mithril-aggregator/src/database/repository/immutable_file_digest_repository.rs
Outdated
Show resolved
Hide resolved
* mithril-aggregator from `0.6.9` to `0.6.10` * mithril-common from `0.4.101` to `0.4.102` * mithril-end-to-end from `0.4.60` to `0.4.61` * openapi.yaml from `0.1.40` to `0.1.41`
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR includes the implementation of the immutable file digests route for
CardanoDatabase
artifacts in the aggregator.Pre-submit checklist
Issue(s)
Closes #2174