Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feat: immutable file digests route for CardanoDatabase artifacts aggregator #2204

Merged

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jan 7, 2025

Content

This PR includes the implementation of the immutable file digests route for CardanoDatabase artifacts in the aggregator.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #2174

@jpraynaud jpraynaud self-assigned this Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

Test Results

    4 files  ± 0     52 suites  ±0   10m 30s ⏱️ ±0s
1 493 tests +14  1 493 ✅ +14  0 💤 ±0  0 ❌ ±0 
1 749 runs  +14  1 749 ✅ +14  0 💤 ±0  0 ❌ ±0 

Results for commit b3cb0d1. ± Comparison against base commit 2256d52.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud temporarily deployed to testing-sanchonet January 7, 2025 17:35 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/2174-digests-route-cardano-database-aggregator branch from 8616fdb to 0cf2629 Compare January 7, 2025 17:42
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet January 7, 2025 19:02 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/2174-digests-route-cardano-database-aggregator branch from 0cf2629 to f1bbaf6 Compare January 8, 2025 10:31
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet January 8, 2025 10:43 — with GitHub Actions Inactive
@jpraynaud jpraynaud marked this pull request as ready for review January 8, 2025 10:50
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Some refactoring suggestions

Copy link
Collaborator

@Alenar Alenar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpraynaud jpraynaud temporarily deployed to testing-sanchonet January 8, 2025 17:01 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit ed1e290 into main Jan 9, 2025
51 of 57 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/2174-digests-route-cardano-database-aggregator branch January 9, 2025 08:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement digests route for Incremental Cardano DB in aggregator REST API
4 participants