Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix: execute Wasm tests on node in CI #2205

Merged
merged 4 commits into from
Jan 9, 2025
Merged

Fix: execute Wasm tests on node in CI #2205

merged 4 commits into from
Jan 9, 2025

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Jan 8, 2025 •
edited
Loading

Content

This PR includes several updates to enable running Wasm tests in Node environments:

  • Adds a test-node feature to the mithril-client-wasm crate to skip code that isn't compatible with Node.
  • Upgrades the default Node version from 18 to 22 in the build-test-wasm step of the CI, ensuring wasm-pack test runs smoothly with node.
  • Closes the BroadcastChannel after usage in handle_event, preventing Wasm tests from hanging indefinitely with node.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #2138

@dlachaume dlachaume changed the title Fix: run client_wasm tests for nodejs in CI Fix: execute Wasm tests on node in CI Jan 8, 2025
@dlachaume dlachaume force-pushed the dlachaume/2138/client-wasm-tests-for-node-js-not-executed branch 2 times, most recently from 93d9e4f to 0b19b9b Compare January 8, 2025 15:13
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025 •
edited
Loading

Test Results

    4 files  ±0     52 suites  ±0   10m 23s ⏱️ +4s
1 493 tests ±0  1 493 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 749 runs  ±0  1 749 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 10bf84d. ± Comparison against base commit ed1e290.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume temporarily deployed to testing-sanchonet January 8, 2025 15:53 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet January 8, 2025 16:28 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the dlachaume/2138/client-wasm-tests-for-node-js-not-executed branch 2 times, most recently from a1cac48 to 75e0186 Compare January 8, 2025 17:07
@dlachaume dlachaume self-assigned this Jan 8, 2025
@dlachaume dlachaume temporarily deployed to testing-sanchonet January 8, 2025 17:25 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the dlachaume/2138/client-wasm-tests-for-node-js-not-executed branch 2 times, most recently from 146334d to 840be27 Compare January 8, 2025 17:33
@dlachaume dlachaume temporarily deployed to testing-sanchonet January 8, 2025 17:52 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the dlachaume/2138/client-wasm-tests-for-node-js-not-executed branch from 840be27 to 7bb6352 Compare January 8, 2025 17:53
@dlachaume dlachaume marked this pull request as ready for review January 8, 2025 17:55
@dlachaume dlachaume temporarily deployed to testing-sanchonet January 8, 2025 18:07 — with GitHub Actions Inactive
jpraynaud
jpraynaud approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dlachaume
fix: execute client_wasm tests for nodejs
7a406f2 
Prevent from executing `certificate_verification_cache.rs` tests that uses
the local storage, which is not supported with node.
@dlachaume
ci: ugrade node version from 18 (default) to 22
0ed753a 
Ensures that `wasm-pack test` runs without issue under Node.
@dlachaume
fix: close BroadcastChannel after usage in handle_event to avoid …
cf390bd 
…blocking with Node
@dlachaume dlachaume force-pushed the dlachaume/2138/client-wasm-tests-for-node-js-not-executed branch from 7bb6352 to cf390bd Compare January 9, 2025 10:11
@dlachaume dlachaume temporarily deployed to testing-sanchonet January 9, 2025 10:21 — with GitHub Actions Inactive
@dlachaume
chore: upgrade crate versions
10bf84d 
* mithril-client-wasm from `0.7.4` to `0.7.5`
* [js] mithril-client-wasm from `0.7.4` to `0.7.5`
@dlachaume dlachaume temporarily deployed to testing-sanchonet January 9, 2025 11:14 — with GitHub Actions Inactive
sfauvel
sfauvel approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlachaume dlachaume merged commit 493c182 into main Jan 9, 2025
51 checks passed
@dlachaume dlachaume deleted the dlachaume/2138/client-wasm-tests-for-node-js-not-executed branch January 9, 2025 11:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@sfauvel sfauvel sfauvel approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

Assignees

@dlachaume dlachaume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Client WASM tests for NodeJS are not executed in the CI
4 participants
@dlachaume @Alenar @sfauvel @jpraynaud