-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Align messages golden master tests #2221
Conversation
Test Results 4 files ±0 52 suites ±0 10m 29s ⏱️ -3s Results for commit 71b01e9. ± Comparison against base commit 584e2c6. This pull request removes 35 and adds 34 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Maybe the naming actual
could be replaced with current
or latest
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We may keep the PR explanation of how we test messages in another place like ADR or documentation.
e88d4cb
to
d926078
Compare
As it wrongly tested that a previous structure could be deserialized into the actual We want to test the other way, that the actual structure can be deserialized into older's, and in this case they were incompatible (the previous structure asked for fields that were removed).
Now they all specify at minimum that they target the 'actual' version and if we test a compatibility with previous messages structure the related openapi version is specified.
…ages golden tests
908071a
to
d4119de
Compare
* mithril-common from `0.4.103` to `0.4.104`
d4119de
to
71b01e9
Compare
Content
This PR align all
mithril-common
messages golden master test to the same test model:CURRENT_JSON
string containing a exhaustive example of json currently exchanged between nodesgolden_message_current
method that returns the representation of theCURRENT_JSON
using the current structuretest_current_json_deserialized_into_current_message
test that check that de-serializing theCURRENT_JSON
into the current structure yield the output stored ingolden_message_current
CertificateMessage
):CertificateMessageUntilV0_1_32
golden_message_until_open_api_X_Y_ZZ
method that returns the representation of theCURRENT_JSON
using the previous structure (also suffixed)test_current_json_deserialized_into_message_supported_until_open_api_X_Y_ZZ
test that check that de-serializing theCURRENT_JSON
into the previous structure yield the output stored ingolden_message_until_open_api_X_Y_ZZ
.Pre-submit checklist
Issue(s)
Closes #2217