Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix: support trailing whitespace in protocol key files #2236

Merged
merged 6 commits into from
Jan 22, 2025
Merged

Fix: support trailing whitespace in protocol key files #2236

merged 6 commits into from
Jan 22, 2025

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jan 20, 2025 •
edited
Loading

Content

This PR includes a fix to the deserialization of the protocol keys to support trailing whitespace in their files.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@jpraynaud jpraynaud self-assigned this Jan 20, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 20, 2025 •
edited
Loading

Test Results

    4 files  ±0     52 suites  ±0   10m 27s ⏱️ -9s
1 532 tests +1  1 532 ✅ +1  0 💤 ±0  0 ❌ ±0 
1 788 runs  +1  1 788 ✅ +1  0 💤 ±0  0 ❌ ±0 

Results for commit efc4d3e. ± Comparison against base commit 98407cd.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud temporarily deployed to testing-sanchonet January 20, 2025 15:36 — with GitHub Actions Inactive
dlachaume
dlachaume approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

sfauvel
sfauvel approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just a suggestion on test

@jpraynaud jpraynaud force-pushed the jpraynaud/fix-trailing-whitespace-genesis-signature branch from 2964a20 to 08d972b Compare January 21, 2025 15:13
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet January 21, 2025 15:39 — with GitHub Actions Inactive
@jpraynaud jpraynaud requested a review from Alenar January 21, 2025 16:13
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet January 21, 2025 16:21 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/fix-trailing-whitespace-genesis-signature branch from a4705e9 to efc4d3e Compare January 22, 2025 09:16
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet January 22, 2025 09:25 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit b6083e6 into main Jan 22, 2025
43 of 44 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/fix-trailing-whitespace-genesis-signature branch January 22, 2025 09:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@sfauvel sfauvel sfauvel approved these changes

@dlachaume dlachaume dlachaume approved these changes

Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jpraynaud @Alenar @sfauvel @dlachaume