Implement a retry mechanism for the FileUploader

[sfauvel]

Content

Extend the FileUploader trait to support a retry mechanism.

This PR includes:

• FileUploader trait extension to support a retry mechanism with a blanket implementation.
• Implement a configurable retry for FileUploaderimplementation
• Configure all file uploaders of the CardanoDatabase with the default retry values (3 retries and 5 seconds delay)

Pre-submit checklist

• Branch
  • Tests are provided (if possible)
  • Crates versions are updated (if relevant)
  • CHANGELOG file is updated (if relevant)
  • Commit sequence broadly makes sense
  • Key commits have useful messages
• PR
  • No clippy warnings in the CI
  • Self-reviewed the diff
  • Useful pull request description
  • Reviewer requested
• Documentation
  • Update README file (if relevant)
  • Update documentation website (if relevant)
  • Add dev blog post (if relevant)

Issue(s)

Closes #2213

[github-actions]

Test Results

    4 files  ±0     52 suites  ±0   10m 15s ⏱️ -1s
1 553 tests +8  1 553 ✅ +8  0 💤 ±0  0 ❌ ±0 
1 809 runs  +8  1 809 ✅ +8  0 💤 ±0  0 ❌ ±0 

Results for commit 26f5996. ± Comparison against base commit dddc0ee.

♻️ This comment has been updated with latest results.

[jpraynaud]

LGTM 👍

[jpraynaud]

Could you add the total number of attempts in this error message?

[sfauvel]

I proposed: "Upload failed after {} attempts"
Do you have a better suggestion ?

[dlachaume]

LGTM 🚀

[dlachaume]

The use of Box doesn't seem necessary.

Suggested change

	let uploader: Box<dyn FileUploader> = Box::new(LocalUploader::new(
	SanitizedUrlWithTrailingSlash::parse("http://test.com:8080/base-root/").unwrap(),
	&target_dir,
	expected_policy.clone(),
	TestLogger::stdout(),
	));
	let uploader = LocalUploader::new(
	SanitizedUrlWithTrailingSlash::parse("http://test.com:8080/base-root/").unwrap(),
	&target_dir,
	expected_policy.clone(),
	TestLogger::stdout(),
	);

[sfauvel]

It's for have a FileUploader and not a LocalUploader to be sure that retry_policy is the function of the trait.
Otherwise, the test pass even if the trait use another function to retrieve policy.
The test name try to explain that (retry_policy_from_file_uploader_trait_should_be_implemented) but it's probably not enough.
Do you think that we have to add a comment here to explain ?
// Cast into FileUploader to be sure it's the trait function that's being implemented

[dlachaume]

Oh I get it, that sounds good to me like that 👍. The test name seems sufficient and clear to me.