Do not delete an already existing archive on error #2257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfauvel
force-pushed
the
sfa/2215/enhance_Snapshotter_to_avoid_file_deletion_on_error
branch
2 times, most recently
from
f99616e to
d99706a
Compare
sfauvel
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
sfauvel
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
jpraynaud
approved these changes
Jan 28, 2025
| @@ -114,6 +114,8 @@ impl CompressedArchiveSnapshotter { | |||
| } | |||
|
|
|||
| fn snapshot<T: TarAppender>(&self, filepath: &Path, appender: T) -> StdResult<OngoingSnapshot> { | |||
| let temporary_archive_path = | |||
There was a problem hiding this comment.
Maybe this could be done more elegantly with Path::with_extension?
There was a problem hiding this comment.
I tried to use it but Path::with_extension replace the extension by the new one, ("archive.tar.gz" become "archive.tar.tmp").
There is also a Path::with_added_extension that just add the extension but it's unstable
sfauvel
force-pushed
the
sfa/2215/enhance_Snapshotter_to_avoid_file_deletion_on_error
branch
from
d99706a to
ed41bb7
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mithril-aggregator/src/services/snapshotter/compressed_archive_snapshotter.rs
Fixed
Show fixed
Hide fixed
mithril-aggregator/src/services/snapshotter/compressed_archive_snapshotter.rs
Fixed
Show fixed
Hide fixed
Alenar
approved these changes
Jan 29, 2025
sfauvel
force-pushed
the
sfa/2215/enhance_Snapshotter_to_avoid_file_deletion_on_error
branch
from
ed41bb7 to
aee9b36
Compare
sfauvel
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
sfauvel
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
sfauvel
force-pushed
the
sfa/2215/enhance_Snapshotter_to_avoid_file_deletion_on_error
branch
from
aee9b36 to
f7d36ea
Compare
* mithril-aggregator from `0.6.23` to `0.6.24`
sfauvel
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
sfauvel
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
sfauvel
deleted the
sfa/2215/enhance_Snapshotter_to_avoid_file_deletion_on_error
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
If an archive exists, it must not be deleted if an error occurs when trying to create an archive with the same name.
We replace an existing snapshotted file only if the snapshotting is successful.
This PR include:
Pre-submit checklist
Issue(s)
Closes #2215