Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Feat: implement CardanoDatabase in mithril-client WASM #2258

Merged
merged 9 commits into from
Jan 29, 2025
Merged

Feat: implement CardanoDatabase in mithril-client WASM #2258

merged 9 commits into from
Jan 29, 2025

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Jan 28, 2025 •
edited
Loading

Content

This PR includes new unstable features for the mithril-client WASM library:

  • list_cardano_database_v2
  • get_cardano_database_v2

A new verification step has been added in ci-test, which can be executed through Mithril Client multi-platform test GitHub workflow.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #2247

@dlachaume dlachaume self-assigned this Jan 28, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 28, 2025 •
edited
Loading

Test Results

    4 files  ±0     52 suites  ±0   10m 19s ⏱️ -16s
1 568 tests +5  1 568 ✅ +5  0 💤 ±0  0 ❌ ±0 
1 842 runs  +5  1 842 ✅ +5  0 💤 ±0  0 ❌ ±0 

Results for commit 55536c7. ± Comparison against base commit 2a50445.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume marked this pull request as ready for review January 28, 2025 17:13
@dlachaume dlachaume temporarily deployed to testing-sanchonet January 28, 2025 17:13 — with GitHub Actions Inactive
@dlachaume dlachaume changed the title Implement CardanoDatabase in mithril-client WASM Feat: implement CardanoDatabase in mithril-client WASM Jan 28, 2025
jpraynaud
jpraynaud reviewed Jan 28, 2025
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

sfauvel
sfauvel approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlachaume dlachaume force-pushed the dlachaume/2247/cardano-db-wasm-client branch from 0f8abf3 to ea30748 Compare January 29, 2025 09:26
@dlachaume dlachaume temporarily deployed to testing-sanchonet January 29, 2025 09:34 — with GitHub Actions Inactive
@dlachaume
chore: reference the feature in the CHANGELOG
755c4c2
@dlachaume
chore: upgrade crate versions
55536c7 
* mithril-build-script from `0.2.15` to `0.2.16`
* mithril-client-wasm from `0.7.5` to `0.7.6`
* mithril-aggregator-fake from `0.3.17` to `0.3.18`
* [js] client-wasm-ci-test from `0.3.3` to `0.3.4`
* [js] mithril-client-wasm from `0.7.5` to `0.7.6`
@dlachaume dlachaume force-pushed the dlachaume/2247/cardano-db-wasm-client branch from 7ddeaa2 to 55536c7 Compare January 29, 2025 09:45
@dlachaume dlachaume temporarily deployed to testing-sanchonet January 29, 2025 09:54 — with GitHub Actions Inactive
@dlachaume dlachaume merged commit 573021d into main Jan 29, 2025
43 of 44 checks passed
@dlachaume dlachaume deleted the dlachaume/2247/cardano-db-wasm-client branch January 29, 2025 10:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@sfauvel sfauvel sfauvel approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

Assignees

@dlachaume dlachaume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Incremental Cardano DB in WASM client
4 participants
@dlachaume @Alenar @sfauvel @jpraynaud