Use tls vendored from reqwest #2260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
dlachaume
approved these changes
Jan 29, 2025
Alenar
force-pushed
the
djo/2252/use-tls-vendored-from-reqwest
branch
from
4434dad to
325686c
Compare
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
By enabling reqwest `native-tls-vendored` feature.
As we will use `native-tls-vendored` throught `reqwest` instead
By gating the `reqwest/native-tls-vendored` feature behind the `bundle_tls` feature (renamed from `bundle_openssl` and added to `mithril-relay` and `mithril-end-to-end`).
As it ask for supplemental dependencies that are not consistent with the other recipes, plus they are not used in the CI.
Alenar
force-pushed
the
djo/2252/use-tls-vendored-from-reqwest
branch
from
325686c to
f5a37f9
Compare
* mithril-aggregator from `0.6.22` to `0.6.23` * mithril-client-cli from `0.10.7` to `0.10.8` * mithril-relay from `0.1.31` to `0.1.32` * mithril-signer from `0.2.224` to `0.2.225` * mithril-end-to-end from `0.4.64` to `0.4.65`
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
12 tasks
3 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR change the way the native TLS library is bundled with our software:
Before we always bundled OpenSSL on every system, even where it had no effect such as with windows and Mac (where a native implementation exist, only linux relies on OpenSSL).
This PR instead use of
reqwestnative-tls-vendoredfeature to bundle the appropriate SSL library for the target system (see native-tls documentation for details).To simplify our build process, this feature is not optional, contrary to the
bundle_opensslfeature it supersede, and is enabled on all relevant binaries (mithril-aggregator,mithril-client-cli,mithril-signer,mithril-relay, andmithril-end-to-end).This change have the added benefit of not needing any-more the costly OpenSSL when building to mac and windows, enabling faster CI time.
Pre-submit checklist
Issue(s)
Closes #2252