Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Refactor: improve variable and function names in fake aggregator #2261

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Refactor: improve variable and function names in fake aggregator #2261

merged 4 commits into from
Jan 29, 2025

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Jan 29, 2025 •
edited
Loading

Content

This PR makes variable and function names clearer in the fake aggregator and in the Mithril client WASM tests by removing abbreviations.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

@dlachaume dlachaume self-assigned this Jan 29, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 29, 2025 •
edited
Loading

Test Results

    4 files  ±0     52 suites  ±0   10m 7s ⏱️ -28s
1 569 tests ±0  1 569 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 843 runs  ±0  1 843 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 90d451b. ± Comparison against base commit a9886c5.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume temporarily deployed to testing-sanchonet January 29, 2025 11:57 — with GitHub Actions Inactive
@dlachaume dlachaume marked this pull request as ready for review January 29, 2025 12:01
jpraynaud
jpraynaud approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

sfauvel
sfauvel approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlachaume
refactor(aggregator-fake): rename variables and functions to avoid co…
cdd9f90 
…nfusing names due to abbreviations
@dlachaume
refactor(build-script): rename fake_aggregator variables and functi…
f2c3f44 
…ons to avoid confusing names due to abbreviations
@dlachaume
refactor(client-wasm): adapt tests to new function names
e45b7a7
@dlachaume
chore: upgrade crate versions
90d451b 
* mithril-build-script from `0.2.16` to `0.2.17`
* mithril-client-wasm from `0.7.6` to `0.7.7`
* mithril-aggregator-fake from `0.3.18` to `0.3.19`
* [js] mithril-client-wasm from `0.7.6` to `0.7.7`
@dlachaume dlachaume force-pushed the dlachaume/renaming-fake-aggregator branch from 3a99c61 to 90d451b Compare January 29, 2025 14:18
@dlachaume dlachaume temporarily deployed to testing-sanchonet January 29, 2025 14:27 — with GitHub Actions Inactive
@dlachaume dlachaume merged commit d6dba71 into main Jan 29, 2025
43 checks passed
@dlachaume dlachaume deleted the dlachaume/renaming-fake-aggregator branch January 29, 2025 14:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@sfauvel sfauvel sfauvel approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

Assignees

@dlachaume dlachaume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dlachaume @Alenar @sfauvel @jpraynaud