Remove mithril common circular dependencies and random feature
#2269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfauvel
force-pushed
the
sfa/2253/remove_mithril_common_circular_dependencies
branch
from
fc18ec8 to
8337329
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sfauvel
force-pushed
the
sfa/2253/remove_mithril_common_circular_dependencies
branch
from
8337329 to
229f619
Compare
sfauvel
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
sfauvel
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
sfauvel
force-pushed
the
sfa/2253/remove_mithril_common_circular_dependencies
branch
from
a0de13c to
7cf6061
Compare
sfauvel
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
sfauvel
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
sfauvel
force-pushed
the
sfa/2253/remove_mithril_common_circular_dependencies
branch
from
7cf6061 to
229f619
Compare
sfauvel
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
sfauvel
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
Alenar
approved these changes
Feb 4, 2025
jpraynaud
approved these changes
Feb 4, 2025
Comment on lines
17
to
20
| pub transactions_hashes: Vec<TransactionHash>, | ||
|
|
||
| /// Proof of the transactions | ||
| transactions_proof: ProtocolMkProof, | ||
| pub transactions_proof: ProtocolMkProof, |
There was a problem hiding this comment.
Do we really want to have these fields public?
There was a problem hiding this comment.
The TryFrom<CardanoTransactionsSetProofMessagePart> for CardanoTransactionsSetProof that uses these fields is moved to the messages module. That's why the visibility change.
We can make them public for the crate (pub(crate)) unless you have an other solution
Move `signed_entity` to `signable_builder` module. Move `Beacon` and `Artifact` implementations in `signable_builder` module.
* mithril-aggregator from `0.6.25` to `0.6.26` * mithril-client from `0.10.9` to `0.10.10` * mithril-common from `0.4.111` to `0.4.112` * mithril-aggregator-fake from `0.3.19` to `0.3.20`
sfauvel
force-pushed
the
sfa/2253/remove_mithril_common_circular_dependencies
branch
from
229f619 to
4c644ae
Compare
sfauvel
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
sfauvel
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
sfauvel
deleted the
sfa/2253/remove_mithril_common_circular_dependencies
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
Preliminary modifications for the
mithril-commonsplit:Pre-submit checklist
Issue(s)
Closes #2253