Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

explorer: Add cardano db v2 support & rework tabs layout #2270

Merged
merged 17 commits into from
Feb 4, 2025

Conversation

Alenar
Copy link
Collaborator

@Alenar Alenar commented Feb 3, 2025

Content

This PR add a new tabs which displays Cardano database v2 artifacts plus a redesign of the tab layout.

Cardano database v2 support

This includes the usual list with a added button that open a popover which allow to download individual files ( ⚠️ without certification).

Demo:

Screencast.from.2025-02-03.16-03-38.webm

Redesign of the tabs layout

The layout is now fully responsive and its style have been aligned to the one used in the status bar.

Before:
image

After:
image

Other adjustments

  • Decreased padding on the lowest breakpoint, below 576px width, to increase content space:

Screenshot 2025-02-03 at 16-10-55 Mithril Explorer

  • Changed default auto-refresh value from 10s to disabled to lessen impact of the explorer to our aggregators.
  • Upgrade to React 19
  • Fix certificate verifier cache not enabled in unstable transaction certification

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #2212

@Alenar Alenar self-assigned this Feb 3, 2025
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Feb 3, 2025

Test Results

    4 files  ±0     56 suites  ±0   10m 38s ⏱️ -1s
1 590 tests ±0  1 590 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 888 runs  ±0  1 888 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8bdabaf. ± Comparison against base commit 3abeead.

♻️ This comment has been updated with latest results.

@Alenar Alenar temporarily deployed to testing-preview February 3, 2025 15:43 — with GitHub Actions Inactive
@Alenar Alenar temporarily deployed to testing-sanchonet February 3, 2025 15:43 — with GitHub Actions Inactive
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Alenar added 17 commits February 4, 2025 09:47
As next 15.1 is compatible with the new React 19.
Since now we can do manual refresh and this allow to lessen the load on
our server + reduce the induced logs.
Except in the certificate verification modal where they are shown only
on hover.
By using a `1.2rem` padding on x axis instead of `2rem`, this add 26
more pixable for content (13 on each side). A sizable difference on
screen with less than 576px horizontally.
…fication

This was because only the certificate validation modal was updated with
cache support.
Solved by introducing a shared function to init the wasm client.
That list the artifacts of the new `CardanoDatabase` signed entity type.

Shown only if enabled on the target aggregator.
This is a tradeoff, we take more vertical space with less data density
for data aligned horizontaly.
This allow to limit the number of time a long string is broken in
several lines
There were usefull when developping, but:
- they are more than 100 times slower than classic jest tests
- the part covered don't justify such slowdown
* [js] mithril-explorer from `0.7.26` to `0.7.27`
@Alenar Alenar force-pushed the djo/2212/explorer/add-cardano-db-v2 branch from 366d6ef to 8bdabaf Compare February 4, 2025 08:48
@Alenar Alenar temporarily deployed to testing-preview February 4, 2025 08:57 — with GitHub Actions Inactive
@Alenar Alenar temporarily deployed to testing-sanchonet February 4, 2025 08:57 — with GitHub Actions Inactive
@Alenar Alenar merged commit 37387c4 into main Feb 4, 2025
43 of 45 checks passed
@Alenar Alenar deleted the djo/2212/explorer/add-cardano-db-v2 branch February 4, 2025 09:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update explorer for Incremental Cardano DB
4 participants