Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Chore: add Mithril client CLI version in debug logs #2273

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Chore: add Mithril client CLI version in debug logs #2273

merged 2 commits into from
Feb 4, 2025

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Feb 4, 2025 •
edited
Loading

Content

This PR adds a new debug log that specifies the version of the Mithril client CLI whenever a command is executed.

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@dlachaume dlachaume self-assigned this Feb 4, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025 •
edited
Loading

Test Results

    4 files  ±0     56 suites  ±0   10m 32s ⏱️ -12s
1 590 tests ±0  1 590 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 888 runs  ±0  1 888 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8efe5f2. ± Comparison against base commit 8ddf19d.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume temporarily deployed to testing-sanchonet February 4, 2025 10:02 — with GitHub Actions Inactive
sfauvel
sfauvel approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlachaume dlachaume force-pushed the dlachaume/add-cli-version-log branch from 4e03501 to 8efe5f2 Compare February 4, 2025 15:36
@dlachaume dlachaume temporarily deployed to testing-sanchonet February 4, 2025 15:46 — with GitHub Actions Inactive
@dlachaume dlachaume merged commit 92ecbe8 into main Feb 4, 2025
43 checks passed
@dlachaume dlachaume deleted the dlachaume/add-cli-version-log branch February 4, 2025 15:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@sfauvel sfauvel sfauvel approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

Assignees

@dlachaume dlachaume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dlachaume @Alenar @sfauvel @jpraynaud