Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add an era subcommand to create keypair #2274

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

sfauvel
Copy link
Collaborator

@sfauvel sfauvel commented Feb 4, 2025

Content

Creation of a command on the aggregator to create test era keys for setting up a test

This PR includes:

  • a new sub-command generate-keypair for the era command to export non deterministic era.sk and era.vk files.
  • a parameter target-path to define the export directory
  • the update of the aggregator documentation

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #2271

Copy link

github-actions bot commented Feb 4, 2025

Test Results

    4 files  ±0     56 suites  ±0   10m 22s ⏱️ -5s
1 591 tests +1  1 591 ✅ +1  0 💤 ±0  0 ❌ ±0 
1 889 runs  +1  1 889 ✅ +1  0 💤 ±0  0 ❌ ±0 

Results for commit 257cb8f. ± Comparison against base commit b4ad474.

♻️ This comment has been updated with latest results.

@sfauvel sfauvel temporarily deployed to testing-preview February 4, 2025 14:09 — with GitHub Actions Inactive
@sfauvel sfauvel temporarily deployed to testing-sanchonet February 4, 2025 14:09 — with GitHub Actions Inactive
@sfauvel sfauvel marked this pull request as ready for review February 4, 2025 14:49
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sfauvel sfauvel force-pushed the sfa/2271/add_command_to_create_keypair branch from c39002b to 33c8bdb Compare February 4, 2025 16:46
@sfauvel sfauvel force-pushed the sfa/2271/add_command_to_create_keypair branch from 33c8bdb to ee359ee Compare February 4, 2025 17:39
@sfauvel sfauvel force-pushed the sfa/2271/add_command_to_create_keypair branch from ee359ee to f998fe7 Compare February 4, 2025 17:43
@sfauvel sfauvel temporarily deployed to testing-preview February 4, 2025 17:52 — with GitHub Actions Inactive
@sfauvel sfauvel temporarily deployed to testing-sanchonet February 4, 2025 17:52 — with GitHub Actions Inactive
* mithril-aggregator from `0.6.26` to `0.6.27`
* mithril-common from `0.4.112` to `0.4.113`
@sfauvel sfauvel temporarily deployed to testing-preview February 4, 2025 18:14 — with GitHub Actions Inactive
@sfauvel sfauvel temporarily deployed to testing-sanchonet February 4, 2025 18:14 — with GitHub Actions Inactive
@sfauvel sfauvel merged commit b797355 into main Feb 4, 2025
43 checks passed
@sfauvel sfauvel deleted the sfa/2271/add_command_to_create_keypair branch February 4, 2025 18:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add command to create Era keypair in aggregator
4 participants