Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Feat: certify protocol parameters and epoch in certificate chain #2276

Merged
merged 11 commits into from
Feb 5, 2025
Merged

Feat: certify protocol parameters and epoch in certificate chain #2276

merged 11 commits into from
Feb 5, 2025

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Feb 4, 2025 •
edited
Loading

Content

This PR includes the certification of the protocol parameters and epoch in the certificate chain.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update documentation website (if relevant)

@jpraynaud jpraynaud self-assigned this Feb 4, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025 •
edited
Loading

Test Results

    4 files  ±0     56 suites  ±0   10m 51s ⏱️ +14s
1 590 tests  - 1  1 590 ✅  - 1  0 💤 ±0  0 ❌ ±0 
1 888 runs   - 1  1 888 ✅  - 1  0 💤 ±0  0 ❌ ±0 

Results for commit b86faf5. ± Comparison against base commit b797355.

This pull request removes 11 and adds 10 tests. Note that renamed tests count towards both. 
mithril-common ‑ certificate_chain::certificate_verifier::tests::verify_certificate_ko_certificate_hash_not_matching
mithril-common ‑ signable_builder::signable_builder_service::tests::pythagoras_era::build_cardano_database_signable_when_given_cardano_database_entity_type
mithril-common ‑ signable_builder::signable_builder_service::tests::pythagoras_era::build_cardano_stake_distribution_signable_when_given_cardano_stake_distribution_entity_type
mithril-common ‑ signable_builder::signable_builder_service::tests::pythagoras_era::build_mithril_stake_distribution_signable_when_given_mithril_stake_distribution_entity_type
mithril-common ‑ signable_builder::signable_builder_service::tests::pythagoras_era::build_snapshot_signable_when_given_cardano_immutable_files_full_entity_type
mithril-common ‑ signable_builder::signable_builder_service::tests::pythagoras_era::build_transactions_signable_when_given_cardano_transactions_entity_type
mithril-common ‑ signable_builder::signable_builder_service::tests::thales_era::build_cardano_database_signable_when_given_cardano_database_entity_type
mithril-common ‑ signable_builder::signable_builder_service::tests::thales_era::build_cardano_stake_distribution_signable_when_given_cardano_stake_distribution_entity_type
mithril-common ‑ signable_builder::signable_builder_service::tests::thales_era::build_mithril_stake_distribution_signable_when_given_mithril_stake_distribution_entity_type
mithril-common ‑ signable_builder::signable_builder_service::tests::thales_era::build_snapshot_signable_when_given_cardano_immutable_files_full_entity_type
…

mithril-common ‑ certificate_chain::certificate_verifier::tests::verify_certificate_chain_fails_when_adversarial_with_registered_signer_forgery_through_protocol_parameters
mithril-common ‑ certificate_chain::certificate_verifier::tests::verify_genesis_certificate_fails_if_epoch_unmatch
mithril-common ‑ certificate_chain::certificate_verifier::tests::verify_standard_certificate_fails_if_certificate_chain_protocol_parameters_unmatch
mithril-common ‑ certificate_chain::certificate_verifier::tests::verify_standard_certificate_fails_if_epoch_unmatch
mithril-common ‑ certificate_chain::certificate_verifier::tests::verify_standard_certificate_fails_if_has_missing_epoch
mithril-common ‑ signable_builder::signable_builder_service::tests::build_cardano_database_signable_when_given_cardano_database_entity_type
mithril-common ‑ signable_builder::signable_builder_service::tests::build_cardano_stake_distribution_signable_when_given_cardano_stake_distribution_entity_type
mithril-common ‑ signable_builder::signable_builder_service::tests::build_mithril_stake_distribution_signable_when_given_mithril_stake_distribution_entity_type
mithril-common ‑ signable_builder::signable_builder_service::tests::build_snapshot_signable_when_given_cardano_immutable_files_full_entity_type
mithril-common ‑ signable_builder::signable_builder_service::tests::build_transactions_signable_when_given_cardano_transactions_entity_type

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud temporarily deployed to testing-sanchonet February 4, 2025 19:01 — with GitHub Actions Inactive
dlachaume
dlachaume approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jpraynaud
chore: update fake aggregator data
eeb792c
@jpraynaud
docs: update CHANGELOG
18d68fb
@jpraynaud
chore: upgrade crate versions
b86faf5 
* mithril-aggregator from `0.6.26` to `0.6.27`
* mithril-common from `0.4.112` to `0.4.113`
* mithril-signer from `0.2.225` to `0.2.226`
* mithril-aggregator-fake from `0.3.20` to `0.3.21`
@jpraynaud jpraynaud force-pushed the jpraynaud/certify-protocol-parameters-certificate-chain branch from a55a2dc to b86faf5 Compare February 5, 2025 09:56
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet February 5, 2025 10:04 — with GitHub Actions Inactive
Alenar
Alenar approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@Alenar Alenar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

sfauvel
sfauvel approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpraynaud jpraynaud merged commit 7cc55d9 into main Feb 5, 2025
38 of 49 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/certify-protocol-parameters-certificate-chain branch February 5, 2025 14:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@sfauvel sfauvel sfauvel approved these changes

@dlachaume dlachaume dlachaume approved these changes

Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jpraynaud @Alenar @sfauvel @dlachaume