Chore: upgrade dependencies #2279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
dlachaume
approved these changes
Feb 5, 2025
sfauvel
approved these changes
Feb 5, 2025
Alenar
force-pushed
the
djo/2207/upgrade-dependencies
branch
from
4e9f236 to
057dd1d
Compare
Else it will make wasm build fails after upgrading `uuid` from version `1.11.0` to `1.13.1`.
Two makefile recipies had their names changes, but those changes were not reflected in the upgrade dep script.
By running 'make upgrade' command.
By running 'make upgrade-ci-test-deps' command.
By running 'make upgrade' command in 'examples/client-wasm-nodejs' and 'examples/client-wasm-web'.
By running 'make upgrade' command.
By running: - 'make install' command in 'examples/client-wasm-web'. - 'make install' command in 'examples/client-wasm-nodejs'. - 'make install' command in 'mithril-explorer'. - 'make install' command in 'docs/website'.
By running 'nix flake update' command.
Alenar
force-pushed
the
djo/2207/upgrade-dependencies
branch
from
057dd1d to
89ca0a2
Compare
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR upgrades the repository dependencies to their latest version by running the upgrade script from the runbook.
Pre-submit checklist
Comments
Some problems had to be fixed:
mithril-clientfailed to compile to wasm: as itsuuiddependency now requires itsjsfeatures for wasm (this features already existed but we could compile to wasm without it before, that's not the case anymore)One problem is remaining:
rand_corereleased it's new major version last week (version 0.9) but it contains breaking changes to their apis, changes that are yet to be reflected on another of our dependency (ed25519-dalek).Since this incompatibility can't be resolved yet, the upgrade script was run with the
--compatibleoption in order to keep the current version ofrand_core(version0.6.4).