Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix: prevent aggregator test conflicts by using unique temporary directories #2280

Merged
merged 3 commits into from
Feb 6, 2025
Merged

Fix: prevent aggregator test conflicts by using unique temporary directories #2280

merged 3 commits into from
Feb 6, 2025

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Feb 5, 2025 •
edited
Loading

Content

This PR fixes some flakiness occurring when running aggregator tests in parallel due to collisions between temporary directory paths.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

@dlachaume dlachaume self-assigned this Feb 5, 2025
@dlachaume dlachaume changed the title Fix: prevent aggregator test conflicts using unique temporary directories Fix: prevent aggregator test conflicts by using unique temporary directories Feb 5, 2025
sfauvel
sfauvel approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025 •
edited
Loading

Test Results

    4 files  ±0     56 suites  ±0   10m 51s ⏱️ -7s
1 590 tests ±0  1 590 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 888 runs  ±0  1 888 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 99c0e71. ± Comparison against base commit 8a646ff.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume temporarily deployed to testing-sanchonet February 5, 2025 15:03 — with GitHub Actions Inactive
jpraynaud
jpraynaud approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlachaume
fix: use a unique directory name to avoid conflicts when tests are ex…
96f1b51 
…ecuted in parallel
@dlachaume
fix: prevent conflicts between tests that verify the archive produced…
68d5754 
… using a `CompressedArchiveSnapshotter` implementation.

Also remove useless `Arc::new()` in `should_create_a_valid_archive_with_gzip_snapshotter` and `should_create_a_valid_archive_with_zstandard_snapshotter` tests.
@dlachaume
chore: upgrade crate versions
99c0e71 
* mithril-aggregator from `0.6.29` to `0.6.30`
@dlachaume dlachaume force-pushed the dlachaume/fix-aggregator-tests-flakiness branch from fc6605b to 99c0e71 Compare February 5, 2025 17:33
@dlachaume dlachaume temporarily deployed to testing-sanchonet February 6, 2025 08:18 — with GitHub Actions Inactive
@dlachaume dlachaume merged commit 527c358 into main Feb 6, 2025
41 of 46 checks passed
@dlachaume dlachaume deleted the dlachaume/fix-aggregator-tests-flakiness branch February 6, 2025 08:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@sfauvel sfauvel sfauvel approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

Assignees

@dlachaume dlachaume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dlachaume @Alenar @sfauvel @jpraynaud