-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix aggregator stress test #2287
Merged
Merged
+46
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pythagoras
as default era value and adapt protocol m…d9734bd
to
27ae3fe
Compare
08c438d
to
59b7842
Compare
bd03a6e
to
2657710
Compare
2657710
to
2a5af5b
Compare
jpraynaud
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Alenar
approved these changes
Feb 10, 2025
* mithril-end-to-end from `0.4.67` to `0.4.68`
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR fixes an issue with the aggregator stress test by implementing the following changes:
mithril-era
fromthales
topythagoras
.NextAggregateVerificationKey
andNextProtocolParameters
.Additionally, the default value for
mithril-era
in the end-to-end tests has been updated fromthales
topythagoras
.Note: These modifications affect the execution time of the aggregator stress test due to the increased size of the messages that need to be signed. Since the aggregator stress test is mainly triggered by a nightly workflow, the impact should be minimal.
Before:
Number of concurrent signers: 500
Number of concurrent clients: 1000
Average execution duration: 3min30s
With the modifications:
Number of concurrent signers: 500
Number of concurrent clients: 1000
Average execution duration: 9min10s
Pre-submit checklist
Issue(s)
Closes #2299