Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix issue #18 #19

Merged
merged 1 commit into from
Jun 20, 2022
Merged

Fix issue #18 #19

merged 1 commit into from
Jun 20, 2022

Conversation

insidieux
Copy link
Owner

Description

  • Fix issue with golang lint
  • Update project golang version to 1.18
  • Add built-in golangci.yml
  • Update project golangci.yml
  • Update built-in Makefile versions
  • Update project Makefile versions

Fixes #18

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • This PR has been tested for backwards compatibility

- Fix issue with golang lint
- Update project golang version to 1.18
- Add built-in golangci.yml
- Update project golangci.yml
- Update built-in Makefile versions
- Update project Makefile versions
@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #19 (d603152) into master (caeeb9d) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #19   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          260       263    +3     
=========================================
+ Hits           260       263    +3     
Impacted Files Coverage Δ
internal/builtin/layout/box.go 100.00% <ø> (ø)
internal/plugins/client.go 100.00% <ø> (ø)
internal/plugins/loader.go 100.00% <ø> (ø)
pkg/sdk/generator/plugin/grpc_plugin.go 100.00% <ø> (ø)
pkg/sdk/generator/plugin/plugin_client.go 100.00% <ø> (ø)
pkg/sdk/generator/plugin/plugin_server.go 100.00% <ø> (ø)
internal/builtin/layout/generator.go 100.00% <100.00%> (ø)
pkg/sdk/generator/plugin/grpc_server.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caeeb9d...d603152. Read the comment docs.

@insidieux insidieux merged commit 687d56a into master Jun 20, 2022
@insidieux insidieux deleted the issue-18-go-linter branch June 20, 2022 12:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove golint from Makefile
1 participant