Issue 29. Add basic authentication quarantine #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on #34 |
ksenia-vazhdaeva
force-pushed
the
issue-29
branch
from
bed8c14 to
06f7e52
Compare
ksenia-vazhdaeva
changed the title
bwsw
requested changes
Aug 13, 2024
docs/source/cookbook/0_https.rst
Outdated
|
|
||
| .. code-block:: bash | ||
|
|
||
| echo "{ |
There was a problem hiding this comment.
Please replace with here docs everything with massive backslash jsons/yamls.
There was a problem hiding this comment.
What is meant by here docs?
There was a problem hiding this comment.
Fixed in #34
| chmod 644 certs/ca.key certs/server.key certs/client.key | ||
|
|
||
| ``certs/*.crt`` is a file with a certificate in PEM format and ``certs/*.key`` is a file with a key in PEM format where ``*`` is a replacement for `ca`, `server` and `client`. | ||
|
|
||
| Launching etcd |
There was a problem hiding this comment.
Change to Etcd (capital letter). Check other places too.
There was a problem hiding this comment.
I used the same writing as in the official documentation - etcd. See https://etcd.io/
| @@ -241,10 +321,6 @@ The configuration below does not contain TLS settings for simplicity. For produc | |||
| \"urls\": [ | |||
There was a problem hiding this comment.
Fixed in #34
ksenia-vazhdaeva
force-pushed
the
issue-29
branch
from
06f7e52 to
b42e503
Compare
ksenia-vazhdaeva
force-pushed
the
issue-29
branch
from
b42e503 to
7fc7334
Compare
ksenia-vazhdaeva
force-pushed
the
issue-29
branch
from
7fc7334 to
a34aa1c
Compare
bwsw
approved these changes
Aug 14, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.