Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix note #180

Merged
merged 2 commits into from
Oct 25, 2022
Merged

fix note #180

merged 2 commits into from
Oct 25, 2022

Conversation

nikolas-burkoff
Copy link
Contributor

@nikolas-burkoff nikolas-burkoff commented Oct 14, 2022 •
edited
Loading

I assume this is OK in the release though

pawelru
pawelru approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@pawelru pawelru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are ok

@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2022 •
edited
Loading

badge

Code Coverage Summary

Filename                           Stmts    Miss  Cover    Missing
-------------------------------  -------  ------  -------  ---------
R/g_boxplot.R                        108     108  0.00%    150-305
R/g_correlationplot.R                129     129  0.00%    252-414
R/g_density_distribution_plot.R       86      86  0.00%    126-237
R/g_lineplot.R                       256     256  0.00%    263-588
R/g_scatterplot.R                    118     118  0.00%    139-294
R/g_spaghettiplot.R                  100     100  0.00%    197-329
R/geom_axes_line.R                   167     167  0.00%    48-370
R/t_summarytable.R                   102     102  0.00%    88-225
R/utils.R                             68      68  0.00%    21-139
TOTAL                               1134    1134  0.00%

Results for commit: 2525bb7

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@pawelru
Copy link
Contributor

pawelru commented Oct 14, 2022

changes are ok however I would hold off with merges or at least confirm with @cicdguy
note that tags are already created

@pawelru pawelru linked an issue Oct 17, 2022 that may be closed by this pull request
R CMD CHECK NOTE #178
Closed
@nikolas-burkoff nikolas-burkoff merged commit 66b2bdc into main Oct 25, 2022
@nikolas-burkoff nikolas-burkoff deleted the fix_note@main branch October 25, 2022 10:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@pawelru pawelru pawelru approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

R CMD CHECK NOTE
2 participants
@nikolas-burkoff @pawelru