Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

113 adding checkmate radpp #120

Merged
merged 2 commits into from
Mar 19, 2022
Merged

113 adding checkmate radpp #120

merged 2 commits into from
Mar 19, 2022

Conversation

codesformochi
Copy link
Contributor

@codesformochi codesformochi commented Mar 18, 2022

Fixes #113

NOTE: the param would not pass assertion with the original data type so it was necessary to change the param data type. documentation has been updated.

@github-actions
Copy link
Contributor

Code Coverage Summary

Filename         Stmts    Miss  Cover    Missing
-------------  -------  ------  -------  --------------------------------------------------------------------------------------
R/radae.R          170       3  98.24%   80, 98, 140
R/radaette.R       210       4  98.10%   51, 72, 78, 242
R/radcm.R          136      27  80.15%   52, 86, 157-183
R/raddv.R           90       3  96.67%   41, 55, 139
R/radeg.R          268       1  99.63%   184
R/radex.R          186       1  99.46%   224
R/radhy.R          136       1  99.26%   197
R/radlb.R          252       1  99.60%   220
R/radmh.R           89       2  97.75%   47, 86
R/radpc.R           57       1  98.25%   97
R/radpp.R           60       1  98.33%   109
R/radqs.R          107       1  99.07%   132
R/radrs.R          120       3  97.50%   49, 55, 155
R/radsaftte.R        1       1  0.00%    17
R/radsl.R          156       2  98.72%   48, 225
R/radsub.R         142       1  99.30%   159
R/radtr.R          127       0  100.00%
R/radtte.R         123       4  96.75%   52, 72, 84, 127
R/radvs.R          160       1  99.38%   174
R/utils.R          154      59  61.69%   9-12, 56-59, 111-112, 117-118, 155-156, 214, 264, 266, 295-301, 305, 338-408, 466, 470
TOTAL             2744     117  95.74%

Results for commit: fb4caa5

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

Unit Tests Summary

  1 files    1 suites   25s ⏱️
21 tests 21 ✔️ 0 💤 0
54 runs  54 ✔️ 0 💤 0

Results for commit bb01024.

@codesformochi
Copy link
Contributor Author

codesformochi commented Mar 18, 2022

i didn't add it here, but now that we add assertions should we add tests that the assertions work as intended?

@shajoezhu shajoezhu enabled auto-merge (squash) March 19, 2022 06:04
@shajoezhu shajoezhu merged commit ee357bd into main Mar 19, 2022
Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks @codesformochi , I think we should be ok with this for now. testing these assertion is a low priority. the checkmate assertion should be sufficient for now. Thanks!

@shajoezhu shajoezhu deleted the 113_adding_checkmate_radpp branch March 19, 2022 06:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve argument validity checking in radpp
2 participants