Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

adab refactoring #154 #168

Merged
merged 4 commits into from
Jul 7, 2022
Merged

adab refactoring #154 #168

merged 4 commits into from
Jul 7, 2022

Conversation

khatril
Copy link
Contributor

@khatril khatril commented Jul 7, 2022

Pull Request

Please review the changes made to ADAB as listed in the issue
note that Time of doses variables have been converted into days

Fixes #154

@khatril khatril added the sme label Jul 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

Code Coverage Summary

Filename         Stmts    Miss  Cover    Missing
-------------  -------  ------  -------  --------------------------------------------------------------------------------------
R/radab.R           86      86  0.00%    34-143
R/radae.R          173       3  98.27%   82, 101, 143
R/radaette.R       211       4  98.10%   52, 73, 79, 243
R/radcm.R          137      27  80.29%   53, 87, 158-184
R/raddv.R           91       3  96.70%   41, 56, 140
R/radeg.R          269       1  99.63%   185
R/radex.R          187       1  99.47%   225
R/radhy.R          136       1  99.26%   197
R/radlb.R          253       1  99.60%   221
R/radmh.R           90       2  97.78%   48, 87
R/radpc.R           60       1  98.33%   100
R/radpp.R           80       1  98.75%   141
R/radqs.R          107       1  99.07%   132
R/radrs.R          121       3  97.52%   49, 56, 156
R/radsaftte.R        1       1  0.00%    17
R/radsl.R          164       1  99.39%   233
R/radsub.R         142       1  99.30%   159
R/radtr.R          127       0  100.00%
R/radtte.R         144       4  97.22%   53, 73, 85, 128
R/radvs.R          160       1  99.38%   174
R/utils.R          154      59  61.69%   9-12, 56-59, 111-112, 117-118, 155-156, 214, 264, 266, 295-301, 305, 338-408, 466, 470
TOTAL             2893     202  93.02%

Results for commit: dcf7cef

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

Unit Tests Summary

  1 files    1 suites   18s ⏱️
23 tests 23 ✔️ 0 💤 0
56 runs  56 ✔️ 0 💤 0

Results for commit 3fff3dc.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @khatril , thanks for the change, can you update the style please

@shajoezhu shajoezhu self-assigned this Jul 7, 2022
Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks @khatril

@khatril khatril merged commit 2ef5c9d into main Jul 7, 2022
@khatril khatril deleted the 154_adab_refactor@main branch July 7, 2022 16:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

radab refactoring
2 participants