Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add ADTHAUT to adsl #200

Merged
merged 6 commits into from
Sep 13, 2022
Merged

Add ADTHAUT to adsl #200

merged 6 commits into from
Sep 13, 2022

Conversation

edelarua
Copy link
Contributor

@edelarua edelarua commented Sep 9, 2022

Closes #199

@edelarua edelarua added the sme label Sep 9, 2022
@edelarua edelarua enabled auto-merge (squash) September 9, 2022 17:01
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2022 •
edited
Loading

Unit Tests Summary

  1 files    1 suites   19s ⏱️
23 tests 23 ✔️ 0 💤 0 ❌
56 runs  56 ✔️ 0 💤 0 ❌

Results for commit db6bcd3.

♻️ This comment has been updated with latest results.

shajoezhu
shajoezhu requested changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @edelarua , thanks for the changes. ADTHAUT looks good. Seems that you have also updated some paths for the data, can you change them back please. Thanks!

@shajoezhu shajoezhu self-assigned this Sep 12, 2022
@edelarua
Copy link
Contributor Author

Hey @shajoezhu sorry about that, the paths have been reverted and it should be good to go now.

@edelarua edelarua requested a review from shajoezhu September 13, 2022 00:22
@edelarua edelarua mentioned this pull request Sep 13, 2022
Merged
shajoezhu
shajoezhu approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brilliant! Thanks @edelarua

@edelarua edelarua merged commit a7a56ca into main Sep 13, 2022
@edelarua edelarua deleted the 199_add_adthaut_to_adsl@main branch September 13, 2022 01:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@shajoezhu shajoezhu shajoezhu approved these changes

Assignees

@shajoezhu shajoezhu

Labels
sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ADTHAUT to adsl
2 participants
@edelarua @shajoezhu