Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Added High and low toxicity variables #211

Merged
merged 12 commits into from
Sep 29, 2022
Merged

Added High and low toxicity variables #211

merged 12 commits into from
Sep 29, 2022

Conversation

nsteed15
Copy link
Contributor

Fixes #205

@nsteed15 nsteed15 added the sme label Sep 29, 2022
shajoezhu
shajoezhu requested changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nolan, can you recompile the cached data cadlb please?

also, BTOXGRL, BTOXGRH, ATOXGRL and ATOXGRH are new right? they should be updated in the meta data. Thanks

@shajoezhu shajoezhu self-assigned this Sep 29, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2022 •
edited
Loading

Unit Tests Summary

  1 files    1 suites   17s ⏱️
23 tests 23 ✔️ 0 💤 0 ❌
56 runs  56 ✔️ 0 💤 0 ❌

Results for commit e925132.

♻️ This comment has been updated with latest results.

shajoezhu
shajoezhu approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey nolan, changes look good. approve to unblock. please recompile the cached data before merge. Thanks!

@nsteed15 nsteed15 merged commit 239ec8a into main Sep 29, 2022
@nsteed15 nsteed15 deleted the 205_ATOX_vars@main branch September 29, 2022 17:23
@shajoezhu shajoezhu mentioned this pull request Sep 29, 2022
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@shajoezhu shajoezhu shajoezhu approved these changes

Assignees

@shajoezhu shajoezhu

Labels
sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add low and high directional toxicity variables
2 participants
@nsteed15 @shajoezhu