Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

254 logical data issues@main #273

Merged
merged 6 commits into from
May 10, 2023
Merged

254 logical data issues@main #273

merged 6 commits into from
May 10, 2023

Conversation

nsteed15
Copy link
Contributor

Fixes #254

@github-actions
Copy link
Contributor

github-actions bot commented Apr 28, 2023

badge

Code Coverage Summary

Filename         Stmts    Miss  Cover    Missing
-------------  -------  ------  -------  --------------------------
R/radab.R          239       1  99.58%   322
R/radae.R          198       3  98.48%   77, 96, 285
R/radaette.R       203       4  98.03%   51, 73, 79, 261
R/radcm.R          150       2  98.67%   52, 205
R/raddv.R           91       2  97.80%   55, 138
R/radeg.R          270       1  99.63%   371
R/radex.R          229       1  99.56%   321
R/radhy.R          136       1  99.26%   199
R/radlb.R          334       1  99.70%   427
R/radmh.R           93       2  97.85%   46, 135
R/radpc.R           74       1  98.65%   124
R/radpp.R           81       1  98.77%   152
R/radqlqc.R        982       7  99.29%   335, 847, 1103-1107
R/radqs.R          118       1  99.15%   186
R/radrs.R          122       3  97.54%   48, 55, 184
R/radsaftte.R        1       0  100.00%
R/radsl.R          180       1  99.44%   262
R/radsub.R         140       2  98.57%   179, 243
R/radtr.R          124       0  100.00%
R/radtte.R         208       4  98.08%   53, 73, 85, 280
R/radvs.R          178       1  99.44%   252
R/utils.R          148      11  92.57%   62, 251, 263, 267, 296-302
TOTAL             4299      50  98.84%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  -------
R/radtte.R      +59       0  +0.76%
TOTAL           +59       0  +0.02%

Results for commit: c60e9b8

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Apr 28, 2023

Unit Tests Summary

    1 files    4 suites   44s ⏱️
  61 tests 40 ✔️ 21 💤 0
106 runs  85 ✔️ 21 💤 0

Results for commit e3e74c6.

♻️ This comment has been updated with latest results.

@nsteed15 nsteed15 added the sme label May 1, 2023
@Melkiades
Copy link
Contributor

Hi @Nolan-Steed! Great job, can I ask you to add also NEWS and a unit test on the fixed variables?

Nolan-Steed added 3 commits May 2, 2023 12:47
Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job @Nolan-Steed! Thanks for taking care of this :) Good to go for me

@nsteed15 nsteed15 merged commit 672cbf7 into main May 10, 2023
@nsteed15 nsteed15 deleted the 254_logical_data_issues@main branch May 10, 2023 11:55
@shajoezhu
Copy link
Contributor

just noticed that the cached data was not recreated in this

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: ADTTE PFS and OS (and likely the others too) are not logical
3 participants